Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v2.7] Emergency webhook release 2.7.14 #4084

Merged
merged 3 commits into from
Jun 13, 2024
Merged

[release-v2.7] Emergency webhook release 2.7.14 #4084

merged 3 commits into from
Jun 13, 2024

Conversation

nicholasSUSE
Copy link
Collaborator

@nicholasSUSE nicholasSUSE commented Jun 13, 2024 •
edited
Loading

Charts:

rancher-webhook 2.0.11+up0.3.11:

Charts Checklist (built for v0.8.1 charts-build-scripts)

Checkpoint 0: Validate release.yaml

Validation steps:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Checkpoint 1: Compare contents of assets/ to charts/

Validation steps:

  • Running make unzip to regenerate the charts/ from scratch, then git diff to check differences between assets/ and charts/ yields NO differences or innocuous differences.

IMPORTANT: Do not undo these changes for future steps since we want to keep the charts/ that match the current contents of assets!

Checkpoint 2: Compare assets against index.yaml

Validation steps:

  • The index.yaml file has an entry for each chart version.
  • The index.yaml entries for each chart matches the Chart.yaml for each chart.
  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@nicholasSUSE
Copy link
Collaborator Author

This is an emergency release.
The approval that will come is my responsibility.
It is needed to run the next CI job.

@nicholasSUSE nicholasSUSE added the regsync-ready PR ready to sync images with prime registry label Jun 13, 2024
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@nicholasSUSE nicholasSUSE merged commit 9a7fb6d into release-v2.7 Jun 13, 2024
6 checks passed
@nicholasSUSE nicholasSUSE deleted the emergency-webhook-release-2.7.14 branch June 13, 2024 14:31
@nicholasSUSE nicholasSUSE mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsokolovsky maxsokolovsky maxsokolovsky approved these changes

@macedogm macedogm macedogm approved these changes

Assignees
No one assigned
Labels
regsync-ready PR ready to sync images with prime registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicholasSUSE @macedogm @maxsokolovsky @pmatseykanets @rancherbot